netdev - Re: [PATCH net-next] bonding: rename AD_STATE_* to BOND_3AD_STATE

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20191224.154254.1245558924785049224.davem@davemloft.net>
Date:   Tue, 24 Dec 2019 15:42:54 -0800 (PST)
From:   David Miller <davem@...emloft.net>
To:     aroulin@...ulusnetworks.com
Cc:     netdev@...r.kernel.org, dsahern@...il.com,
        nikolay@...ulusnetworks.com, roopa@...ulusnetworks.com,
        j.vosburgh@...il.com, vfalico@...il.com, andy@...yhouse.net
Subject: Re: [PATCH net-next] bonding: rename AD_STATE_* to BOND_3AD_STATE_*

From: Andy Roulin <aroulin@...ulusnetworks.com>
Date: Thu, 19 Dec 2019 15:32:59 -0800

> As the LACP states are now part of the uapi, rename the
> 3ad state defines with BOND_3AD prefix. This way, the naming
> is consistent with the the rest of the bonding uapi.
> 
> Signed-off-by: Andy Roulin <aroulin@...ulusnetworks.com>
> Acked-by: Roopa Prabhu <roopa@...ulusnetworks.com>

When the next version of this is posted please provide an appropriate
Fixes: tag.

My understanding of this situaion is that we only started putting this in
the UAPI header in the current merge window, which is why it is valid to
change UAPI like this.

If you provided an appropriate Fixes: tag, it would have been very clear
to me that this is in fact the case.