netdev - Re: [PATCH net-next v8 06/14] ethtool: provide string sets with STRSET

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <548c0a25-9366-05d5-2182-ba50b5c240aa@gmail.com>
Date:   Mon, 23 Dec 2019 20:28:33 -0800
From:   Florian Fainelli <f.fainelli@...il.com>
To:     Michal Kubecek <mkubecek@...e.cz>,
        David Miller <davem@...emloft.net>, netdev@...r.kernel.org
Cc:     Jakub Kicinski <jakub.kicinski@...ronome.com>,
        Jiri Pirko <jiri@...nulli.us>, Andrew Lunn <andrew@...n.ch>,
        John Linville <linville@...driver.com>,
        Stephen Hemminger <stephen@...workplumber.org>,
        Johannes Berg <johannes@...solutions.net>,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH net-next v8 06/14] ethtool: provide string sets with
 STRSET_GET request



On 12/22/2019 3:45 PM, Michal Kubecek wrote:
> Requests a contents of one or more string sets, i.e. indexed arrays of
> strings; this information is provided by ETHTOOL_GSSET_INFO and
> ETHTOOL_GSTRINGS commands of ioctl interface. Unlike ioctl interface, all
> information can be retrieved with one request and mulitple string sets can
> be requested at once.
> 
> There are three types of requests:
> 
>   - no NLM_F_DUMP, no device: get "global" stringsets
>   - no NLM_F_DUMP, with device: get string sets related to the device
>   - NLM_F_DUMP, no device: get device related string sets for all devices
> 
> Client can request either all string sets of given type (global or device
> related) or only specific sets. With ETHTOOL_A_STRSET_COUNTS flag set, only
> set sizes (numbers of strings) are returned.
> 
> Signed-off-by: Michal Kubecek <mkubecek@...e.cz>

Reviewed-by: Florian Fainelli <f.fainelli@...il.com>
-- 
Florian