lists.openwall.net   lists  /  announce  owl-users  owl-dev  john-users  john-dev  passwdqc-users  yescrypt  popa3d-users  /  oss-security  kernel-hardening  musl  sabotage  tlsify  passwords  /  crypt-dev  xvendor  /  Bugtraq  Full-Disclosure  linux-kernel  linux-netdev  linux-ext4  linux-hardening  linux-cve-announce  PHC 
Open Source and information security mailing list archives
 
Hash Suite: Windows password security audit tool. GUI, reports in PDF.
[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <20191224112515.GE3395@lunn.ch>
Date:   Tue, 24 Dec 2019 12:25:15 +0100
From:   Andrew Lunn <andrew@...n.ch>
To:     Mao Wenan <maowenan@...wei.com>
Cc:     vivien.didelot@...il.com, f.fainelli@...il.com,
        davem@...emloft.net, linux@...pel-privat.de,
        netdev@...r.kernel.org, linux-kernel@...r.kernel.org,
        kernel-janitors@...r.kernel.org
Subject: Re: [PATCH net-next] net: dsa: drop pointless static qualifier in
 ar9331_sw_mbus_init

On Tue, Dec 24, 2019 at 10:40:59AM +0800, Mao Wenan wrote:
> There is no need to have the 'T *v' variable static

What does 'T *v' mean?

The patch itself looks O.K, but the description should be better, and
the subject line.

    Andrew

Powered by blists - more mailing lists

Powered by Openwall GNU/*/Linux Powered by OpenVZ