netdev - Re: [PATCH net-next] qede: Implement ndo_tx

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Tue, 24 Dec 2019 22:35:28 -0800 (PST)
From:   David Miller <davem@...emloft.net>
To:     dbolotin@...vell.com
Cc:     netdev@...r.kernel.org, aelior@...vell.com
Subject: Re: [PATCH net-next] qede: Implement ndo_tx_timeout

From: Denis Bolotin <dbolotin@...vell.com>
Date: Sun, 22 Dec 2019 16:07:22 +0200

> Disable carrier and print TX queue info on TX timeout.
> 
> Signed-off-by: Denis Bolotin <dbolotin@...vell.com>
> Signed-off-by: Ariel Elior <aelior@...vell.com>

You need to do more than just dump some state.

You have to actually reset the device so that there is a chance that
packets can start flowing again.

If the network is the only way administrators can access the machine
or see the log messages, your state dump will be seen by no-one unless
you reset the device and get it working again.

I'm not applying this, sorry.