netdev - Re: [PATCH net-next v8 00/14] ethtool netlink interface, part 1

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20191224.231835.1355628010065210167.davem@davemloft.net>
Date:   Tue, 24 Dec 2019 23:18:35 -0800 (PST)
From:   David Miller <davem@...emloft.net>
To:     mkubecek@...e.cz
Cc:     netdev@...r.kernel.org, jakub.kicinski@...ronome.com,
        jiri@...nulli.us, andrew@...n.ch, f.fainelli@...il.com,
        linville@...driver.com, stephen@...workplumber.org,
        johannes@...solutions.net, linux-kernel@...r.kernel.org
Subject: Re: [PATCH net-next v8 00/14] ethtool netlink interface, part 1

From: Michal Kubecek <mkubecek@...e.cz>
Date: Mon, 23 Dec 2019 00:45:14 +0100 (CET)

> This is first part of netlink based alternative userspace interface for
> ethtool. It aims to address some long known issues with the ioctl
> interface, mainly lack of extensibility, raciness, limited error reporting
> and absence of notifications. The goal is to allow userspace ethtool
> utility to provide all features it currently does but without using the
> ioctl interface. However, some features provided by ethtool ioctl API will
> be available through other netlink interfaces (rtnetlink, devlink) if it's
> more appropriate.
 ...

Please address the feedback for patch #3 (especially the u32-->u8 thing) and
then this series should be good to go!

Thanks!