netdev - Re: [PATCH] ip: xfrm if_id -ve value is error

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20191225123825.4e4ddef9@hermes.lan>
Date:   Wed, 25 Dec 2019 12:38:25 -0800
From:   Stephen Hemminger <stephen@...workplumber.org>
To:     Antony Antony <antony@...nome.org>
Cc:     netdev@...r.kernel.org, Matt Ellison <matt@...oyo.io>,
        Nicolas Dichtel <nicolas.dichtel@...nd.com>
Subject: Re: [PATCH] ip: xfrm if_id -ve value is error

On Thu, 19 Dec 2019 15:18:03 +0100
Antony Antony <antony@...nome.org> wrote:

> if_id is u32, error on -ve values instead of setting to 0
> 
> after :
>  ip link add ipsec1 type xfrm dev lo if_id -10
>  Error: argument "-10" is wrong: if_id value is invalid
> 
> before : note xfrm if_id 0
>  ip link add ipsec1 type xfrm dev lo if_id -10
>  ip -d  link show dev ipsec1
>  9: ipsec1@lo: <NOARP> mtu 1500 qdisc noop state DOWN mode DEFAULT group default qlen 1000
>     link/none 00:00:00:00:00:00 brd ff:ff:ff:ff:ff:ff promiscuity 0 minmtu 68 maxmtu 1500
>     xfrm if_id 0 addrgenmode eui64 numtxqueues 1 numrxqueues 1 gso_max_size 65536 gso_max_segs 65535
> 
> Fixes: 286446c1e8c ("ip: support for xfrm interfaces")
> 
> Signed-off-by: Antony Antony <antony@...nome.org>

Applied.