netdev - Re: [PATCH net 0/3] rxrpc: Fixes

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Tue, 24 Dec 2019 16:15:39 -0800 (PST)
From:   David Miller <davem@...emloft.net>
To:     dhowells@...hat.com
Cc:     netdev@...r.kernel.org, linux-afs@...ts.infradead.org,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH net 0/3] rxrpc: Fixes

From: David Howells <dhowells@...hat.com>
Date: Fri, 20 Dec 2019 23:05:19 +0000

> 
> Here are a couple of bugfixes plus a patch that makes one of the bugfixes
> easier:
> 
>  (1) Move the ping and mutex unlock on a new call from rxrpc_input_packet()
>      into rxrpc_new_incoming_call(), which it calls.  This means the
>      lock-unlock section is entirely within the latter function.  This
>      simplifies patch (2).
> 
>  (2) Don't take the call->user_mutex at all in the softirq path.  Mutexes
>      aren't allowed to be taken or released there and a patch was merged
>      that caused a warning to be emitted every time this happened.  Looking
>      at the code again, it looks like that taking the mutex isn't actually
>      necessary, as the value of call->state will block access to the call.
> 
>  (3) Fix the incoming call path to check incoming calls earlier to reject
>      calls to RPC services for which we don't have a security key of the
>      appropriate class.  This avoids an assertion failure if YFS tries
>      making a secure call to the kafs cache manager RPC service.
> 
> The patches are tagged here:
> 
> 	git://git.kernel.org/pub/scm/linux/kernel/git/dhowells/linux-fs.git
> 	rxrpc-fixes-20191220

Pulled, thanks David.