netdev - Re: [PATCH net-next 2/2] net: Warning about use of deprecated TX checksum offload

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20191226.134139.1734199063143329763.davem@davemloft.net>
Date:   Thu, 26 Dec 2019 13:41:39 -0800 (PST)
From:   David Miller <davem@...emloft.net>
To:     tom@...bertland.com
Cc:     netdev@...r.kernel.org
Subject: Re: [PATCH net-next 2/2] net: Warning about use of deprecated TX
 checksum offload

From: Tom Herbert <tom@...bertland.com>
Date: Thu, 26 Dec 2019 13:34:59 -0800

> +	/* NETIF_F_IP_CSUM and NETIF_F_IPV6_CSUM are deprecated */
> +	if (features & (NETIF_F_IP_CSUM | NETIF_F_IPV6_CSUM))
> +		netdev_warn(dev, "NETIF_F_IP_CSUM and NETIF_F_IPV6_CSUM are considered deprecated. Please fix driver to use NETIF_F_HW_CSUM.\n");

So let's put useless messages in people's kernel logs because grep
apparently doesn't work on your computer?

Fix drivers that use that flag that you care about.

No way I am applying this series, it is ill conceived.