lists  /  announce  owl-users  owl-dev  john-users  john-dev  passwdqc-users  yescrypt  popa3d-users  /  oss-security  kernel-hardening  musl  sabotage  tlsify  passwords  /  crypt-dev  xvendor  /  Bugtraq  Full-Disclosure  linux-kernel  linux-netdev  linux-ext4  linux-hardening  PHC 
Open Source and information security mailing list archives
Hash Suite: Windows password security audit tool. GUI, reports in PDF.
[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Date:   Thu, 26 Dec 2019 22:47:40 +0000
From:   Martin Lau <>
To:     Andrii Nakryiko <>
CC:     bpf <>, Alexei Starovoitov <>,
        "Daniel Borkmann" <>,
        David Miller <>,
        "Kernel Team" <>,
        Networking <>
Subject: Re: [PATCH bpf-next v2 10/11] bpf: libbpf: Add STRUCT_OPS support

On Mon, Dec 23, 2019 at 11:54:17AM -0800, Andrii Nakryiko wrote:
> > -       for (i = 0; i < obj->nr_maps; i++)
> > +       for (i = 0; i < obj->nr_maps; i++) {
> >                 zclose(obj->maps[i].fd);
> > +               if (obj->maps[i].st_ops)
> > +                       zfree(&obj->maps[i].st_ops->kern_vdata);
> any specific reason to deallocate only kern_vdata? maybe just
> consolidate all the clean up in bpf_object__close instead?
I think it is the same as why the map fd is closed here.
kern_vdata is allocated at load time, so it seems more
logical to me to deallocate asap at unload time.
For example, if user calls bpf_object__load_xattr()
and one of the load steps fails, bpf_object__unload
(but not bpf_object__close) is called before returning.

Powered by blists - more mailing lists