netdev - Re: [PATCH net-next v2] bonding: rename AD_STATE_* to LACP_STATE

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20191226182042.3ca9cd94@hermes.lan>
Date:   Thu, 26 Dec 2019 18:20:42 -0800
From:   Stephen Hemminger <stephen@...workplumber.org>
To:     Andy Roulin <aroulin@...ulusnetworks.com>
Cc:     netdev@...r.kernel.org, dsahern@...il.com,
        nikolay@...ulusnetworks.com, roopa@...ulusnetworks.com,
        j.vosburgh@...il.com, vfalico@...il.com, andy@...yhouse.net
Subject: Re: [PATCH net-next v2] bonding: rename AD_STATE_* to LACP_STATE_*

On Thu, 26 Dec 2019 05:41:57 -0800
Andy Roulin <aroulin@...ulusnetworks.com> wrote:

> diff --git a/include/uapi/linux/if_bonding.h b/include/uapi/linux/if_bonding.h
> index 6829213a54c5..45f3750aa861 100644
> --- a/include/uapi/linux/if_bonding.h
> +++ b/include/uapi/linux/if_bonding.h
> @@ -96,14 +96,14 @@
>  #define BOND_XMIT_POLICY_ENCAP34	4 /* encapsulated layer 3+4 */
>  
>  /* 802.3ad port state definitions (43.4.2.2 in the 802.3ad standard) */
> -#define AD_STATE_LACP_ACTIVITY   0x1
> -#define AD_STATE_LACP_TIMEOUT    0x2
> -#define AD_STATE_AGGREGATION     0x4
> -#define AD_STATE_SYNCHRONIZATION 0x8
> -#define AD_STATE_COLLECTING      0x10
> -#define AD_STATE_DISTRIBUTING    0x20
> -#define AD_STATE_DEFAULTED       0x40
> -#define AD_STATE_EXPIRED         0x80
> +#define LACP_STATE_LACP_ACTIVITY   0x1
> +#define LACP_STATE_LACP_TIMEOUT    0x2
> +#define LACP_STATE_AGGREGATION     0x4
> +#define LACP_STATE_SYNCHRONIZATION 0x8
> +#define LACP_STATE_COLLECTING      0x10
> +#define LACP_STATE_DISTRIBUTING    0x20
> +#define LACP_STATE_DEFAULTED       0x40
> +#define LACP_STATE_EXPIRED         0x80

You can't change definitions of headers in userspace api
without breaking compatibility.