netdev - Re: [PATCHv3 net-next] sctp: do trace_sctp_probe after SACK validation and check

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20191227.163613.94954890256147556.davem@davemloft.net>
Date:   Fri, 27 Dec 2019 16:36:13 -0800 (PST)
From:   David Miller <davem@...emloft.net>
To:     qdkevin.kou@...il.com
Cc:     linux-sctp@...r.kernel.org, netdev@...r.kernel.org,
        vyasevich@...il.com, nhorman@...driver.com,
        marcelo.leitner@...il.com
Subject: Re: [PATCHv3 net-next] sctp: do trace_sctp_probe after SACK
 validation and check

From: Kevin Kou <qdkevin.kou@...il.com>
Date: Wed, 25 Dec 2019 08:27:25 +0000

> The function sctp_sf_eat_sack_6_2 now performs the Verification
> Tag validation, Chunk length validation, Bogu check, and also
> the detection of out-of-order SACK based on the RFC2960
> Section 6.2 at the beginning, and finally performs the further
> processing of SACK. The trace_sctp_probe now triggered before
> the above necessary validation and check.
> 
> this patch is to do the trace_sctp_probe after the chunk sanity
> tests, but keep doing trace if the SACK received is out of order,
> for the out-of-order SACK is valuable to congestion control
> debugging.
> 
> v1->v2:
>  - keep doing SCTP trace if the SACK is out of order as Marcelo's
>    suggestion.
> v2->v3:
>  - regenerate the patch as v2 generated on top of v1, and add
>    'net-next' tag to the new one as Marcelo's comments.
> 
> Signed-off-by: Kevin Kou <qdkevin.kou@...il.com>

Applied.