lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Sat, 28 Dec 2019 16:13:18 -0800 From: Stephen Hemminger <stephen@...workplumber.org> To: Haiyang Zhang <haiyangz@...rosoft.com> Cc: sashal@...nel.org, linux-hyperv@...r.kernel.org, netdev@...r.kernel.org, kys@...rosoft.com, sthemmin@...rosoft.com, olaf@...fle.de, vkuznets@...hat.com, davem@...emloft.net, linux-kernel@...r.kernel.org Subject: Re: [PATCH net-next, 3/3] hv_netvsc: Name NICs based on vmbus offer sequence and use async probe On Sat, 28 Dec 2019 15:46:33 -0800 Haiyang Zhang <haiyangz@...rosoft.com> wrote: > - net = alloc_etherdev_mq(sizeof(struct net_device_context), > - VRSS_CHANNEL_MAX); > + snprintf(name, IFNAMSIZ, "eth%d", dev->channel->dev_num); > + net = alloc_netdev_mqs(sizeof(struct net_device_context), name, > + NET_NAME_ENUM, ether_setup, > + VRSS_CHANNEL_MAX, VRSS_CHANNEL_MAX); > + Naming is a hard problem, and best left to userspace. By choosing ethN as a naming policy, you potentially run into naming conflicts with other non netvsc devices like those passed through or SR-IOV devices. Better to have udev use dev_num and use something like envN or something. Udev also handles SRIOV devices in later versions. Fighting against systemd, netplan, etc is not going to be make friends.
Powered by blists - more mailing lists