netdev - Re: [PATCH] tcp: Fix tcp_max_syn_backlog limit on connection requests

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Mon, 30 Dec 2019 12:03:51 +0000
From:   Ttttabcd <ttttabcd@...tonmail.com>
To:     kbuild test robot <lkp@...el.com>
Cc:     "kbuild-all@...ts.01.org" <kbuild-all@...ts.01.org>,
        Netdev <netdev@...r.kernel.org>,
        "edumazet@...gle.com" <edumazet@...gle.com>,
        David Miller <davem@...emloft.net>,
        "kuznet@....inr.ac.ru" <kuznet@....inr.ac.ru>,
        "yoshfuji@...ux-ipv6.org" <yoshfuji@...ux-ipv6.org>
Subject: Re: [PATCH] tcp: Fix tcp_max_syn_backlog limit on connection requests

> Hi Ttttabcd,
>
> Thank you for the patch! Perhaps something to improve:
>

> If you fix the issue, kindly add following tag
> Reported-by: kbuild test robot lkp@...el.com
>
> All warnings (new ones prefixed by >>):
>
> In file included from include/asm-generic/bug.h:19:0,
> from ./arch/um/include/generated/asm/bug.h:1,
> from include/linux/bug.h:5,
> from include/linux/mmdebug.h:5,
> from include/linux/mm.h:9,
> from net/ipv4/tcp_input.c:67:
> net/ipv4/tcp_input.c: In function 'tcp_conn_request':
> include/linux/kernel.h:844:29: warning: comparison of distinct pointer types lacks a cast
> (!!(sizeof((typeof(x) *)1 == (typeof(y) *)1)))
> ^
> include/linux/kernel.h:858:4: note: in expansion of macro '__typecheck'
> (__typecheck(x, y) && __no_side_effects(x, y))
> ^~~~~~~~~~~
> include/linux/kernel.h:868:24: note: in expansion of macro '__safe_cmp'
> __builtin_choose_expr(__safe_cmp(x, y), \
> ^~~~~~~~~~
> include/linux/kernel.h:877:19: note: in expansion of macro '__careful_cmp'
> #define min(x, y) __careful_cmp(x, y, <)
> ^~~~~~~~~~~~~
>
> > > net/ipv4/tcp_input.c:6568:20: note: in expansion of macro 'min'
>
>      max_syn_backlog = min(net->ipv4.sysctl_max_syn_backlog,
>
>                        ^~~

Uh ... I can not solve this warning, it's none of my business, but the kernel is also used elsewhere min (), and there is no problem.