netdev - Re: [PATCH iproute2-next] ip: ipneigh: json: print ndm

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <53f116f6-f744-2f38-029e-c978f3a99f11@gmail.com>
Date:   Mon, 30 Dec 2019 10:38:49 -0700
From:   David Ahern <dsahern@...il.com>
To:     Stephen Hemminger <stephen@...workplumber.org>,
        Julien Fortin <julien@...ulusnetworks.com>
Cc:     netdev@...r.kernel.org, roopa@...ulusnetworks.com,
        dsahern@...il.com
Subject: Re: [PATCH iproute2-next] ip: ipneigh: json: print ndm_flags as
 boolean attributes

On 12/26/19 10:04 AM, Stephen Hemminger wrote:
> On Thu, 26 Dec 2019 15:44:15 +0100
> Julien Fortin <julien@...ulusnetworks.com> wrote:
> 
>> From: Julien Fortin <julien@...ulusnetworks.com>
>>
>> Today the following attributes are printed as json "null" attributes
>> NTF_ROUTER
>> NTF_PROXY
>> NTF_EXT_LEARNED
>> NTF_OFFLOADED
>>
>> $ ip -j neigh show
>> [
>>   {
>>     "dst": "10.0.2.2",
>>     "dev": "enp0s3",
>>     "lladdr": "52:54:00:12:35:02",
>>     "router": null,
>>     "proxy": null,
>>     "extern_learn": null,
>>     "offload": null,
>>     "state": [
>>       "REACHABLE"
>>     ]
>>   }
>> ]
> 
> 
> No, this was intentional. Null is a standard method in JSON
> to encode an option being present.
> 

seems weird for flags. ip mostly uses print_bool for flags; there are
only a few print_null.