lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Tue, 31 Dec 2019 05:53:31 +0800 From: kbuild test robot <lkp@...el.com> To: Ttttabcd <ttttabcd@...tonmail.com> Cc: kbuild-all@...ts.01.org, Netdev <netdev@...r.kernel.org>, "edumazet@...gle.com" <edumazet@...gle.com>, David Miller <davem@...emloft.net>, "kuznet@....inr.ac.ru" <kuznet@....inr.ac.ru>, "yoshfuji@...ux-ipv6.org" <yoshfuji@...ux-ipv6.org> Subject: Re: [PATCH] tcp: Fix tcp_max_syn_backlog limit on connection requests Hi Ttttabcd, Thank you for the patch! Perhaps something to improve: [auto build test WARNING on net/master] [also build test WARNING on net-next/master ipvs/master v5.5-rc4 next-20191220] [if your patch is applied to the wrong git tree, please drop us a note to help improve the system. BTW, we also suggest to use '--base' option to specify the base tree in git format-patch, please see https://stackoverflow.com/a/37406982] url: https://github.com/0day-ci/linux/commits/Ttttabcd/tcp-Fix-tcp_max_syn_backlog-limit-on-connection-requests/20191230-164004 base: https://git.kernel.org/pub/scm/linux/kernel/git/davem/net.git bb3d0b8bf5be61ab1d6f472c43cbf34de17e796b reproduce: # apt-get install sparse # sparse version: v0.6.1-129-g341daf20-dirty make ARCH=x86_64 allmodconfig make C=1 CF='-fdiagnostic-prefix -D__CHECK_ENDIAN__' If you fix the issue, kindly add following tag Reported-by: kbuild test robot <lkp@...el.com> sparse warnings: (new ones prefixed by >>) >> net/ipv4/tcp_input.c:6568:27: sparse: sparse: incompatible types in comparison expression (different signedness): >> net/ipv4/tcp_input.c:6568:27: sparse: int * >> net/ipv4/tcp_input.c:6568:27: sparse: unsigned int * net/ipv4/tcp_input.c:6673:17: sparse: sparse: context imbalance in 'tcp_conn_request' - unexpected unlock vim +6568 net/ipv4/tcp_input.c 6551 6552 int tcp_conn_request(struct request_sock_ops *rsk_ops, 6553 const struct tcp_request_sock_ops *af_ops, 6554 struct sock *sk, struct sk_buff *skb) 6555 { 6556 struct tcp_fastopen_cookie foc = { .len = -1 }; 6557 __u32 isn = TCP_SKB_CB(skb)->tcp_tw_isn; 6558 struct tcp_options_received tmp_opt; 6559 struct tcp_sock *tp = tcp_sk(sk); 6560 struct net *net = sock_net(sk); 6561 struct sock *fastopen_sk = NULL; 6562 struct request_sock *req; 6563 bool want_cookie = false; 6564 struct dst_entry *dst; 6565 int max_syn_backlog; 6566 struct flowi fl; 6567 > 6568 max_syn_backlog = min(net->ipv4.sysctl_max_syn_backlog, --- 0-DAY kernel test infrastructure Open Source Technology Center https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org Intel Corporation
Powered by blists - more mailing lists