netdev - Re: [PATCH net] hsr: fix slab-out-of-bounds Read in hsr_debugfs

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Tue, 31 Dec 2019 00:51:22 -0800 (PST)
From:   David Miller <davem@...emloft.net>
To:     ap420073@...il.com
Cc:     jakub.kicinski@...ronome.com, netdev@...r.kernel.org
Subject: Re: [PATCH net] hsr: fix slab-out-of-bounds Read in
 hsr_debugfs_rename()

From: Taehee Yoo <ap420073@...il.com>
Date: Sat, 28 Dec 2019 16:28:09 +0000

> hsr slave interfaces don't have debugfs directory.
> So, hsr_debugfs_rename() shouldn't be called when hsr slave interface name
> is changed.
> 
> Test commands:
>     ip link add dummy0 type dummy
>     ip link add dummy1 type dummy
>     ip link add hsr0 type hsr slave1 dummy0 slave2 dummy1
>     ip link set dummy0 name ap
> 
> Splat looks like:
 ...
> Reported-by: syzbot+9328206518f08318a5fd@...kaller.appspotmail.com
> Fixes: 4c2d5e33dcd3 ("hsr: rename debugfs file when interface name is changed")
> Signed-off-by: Taehee Yoo <ap420073@...il.com>

Applied, thank you.