netdev - [PATCH] sch_cake: avoid possible divide by zero in cake

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [thread-next>] [day] [month] [year] [list]

Message-Id: <20200102092143.8971-1-wenyang@linux.alibaba.com>
Date:   Thu,  2 Jan 2020 17:21:43 +0800
From:   Wen Yang <wenyang@...ux.alibaba.com>
To:     Toke Høiland-Jørgensen <toke@...e.dk>
Cc:     Wen Yang <wenyang@...ux.alibaba.com>,
        Kevin Darbyshire-Bryant <ldir@...byshire-bryant.me.uk>,
        Toke Høiland-Jørgensen <toke@...hat.com>,
        "David S . Miller" <davem@...emloft.net>,
        Cong Wang <xiyou.wangcong@...il.com>,
        cake@...ts.bufferbloat.net, netdev@...r.kernel.org,
        linux-kernel@...r.kernel.org
Subject: [PATCH] sch_cake: avoid possible divide by zero in cake_enqueue()

The variables 'window_interval' is u64 and do_div()
truncates it to 32 bits, which means it can test
non-zero and be truncated to zero for division.
The unit of window_interval is nanoseconds,
so its lower 32-bit is relatively easy to exceed.
Fix this issue by using div64_u64() instead.

Fixes: 7298de9cd725 ("sch_cake: Add ingress mode")
Signed-off-by: Wen Yang <wenyang@...ux.alibaba.com>
Cc: Kevin Darbyshire-Bryant <ldir@...byshire-bryant.me.uk>
Cc: Toke Høiland-Jørgensen <toke@...hat.com>
Cc: David S. Miller <davem@...emloft.net>
Cc: Cong Wang <xiyou.wangcong@...il.com>
Cc: cake@...ts.bufferbloat.net
Cc: netdev@...r.kernel.org
Cc: linux-kernel@...r.kernel.org
---
 net/sched/sch_cake.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/net/sched/sch_cake.c b/net/sched/sch_cake.c
index 6cc3ab1..90ef7cc 100644
--- a/net/sched/sch_cake.c
+++ b/net/sched/sch_cake.c
@@ -1768,7 +1768,7 @@ static s32 cake_enqueue(struct sk_buff *skb, struct Qdisc *sch,
 						      q->avg_window_begin));
 			u64 b = q->avg_window_bytes * (u64)NSEC_PER_SEC;
 
-			do_div(b, window_interval);
+			b = div64_u64(b, window_interval);
 			q->avg_peak_bandwidth =
 				cake_ewma(q->avg_peak_bandwidth, b,
 					  b > q->avg_peak_bandwidth ? 2 : 8);
-- 
1.8.3.1