[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <VE1PR04MB6496E2419F471AF65339E7C892200@VE1PR04MB6496.eurprd04.prod.outlook.com>
Date: Thu, 2 Jan 2020 02:16:42 +0000
From: Po Liu <po.liu@....com>
To: David Miller <davem@...emloft.net>
CC: "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
"netdev@...r.kernel.org" <netdev@...r.kernel.org>,
"vinicius.gomes@...el.com" <vinicius.gomes@...el.com>,
Claudiu Manoil <claudiu.manoil@....com>,
Vladimir Oltean <vladimir.oltean@....com>,
Alexandru Marginean <alexandru.marginean@....com>,
Xiaoliang Yang <xiaoliang.yang_1@....com>,
Roy Zang <roy.zang@....com>, Mingkai Hu <mingkai.hu@....com>,
Jerry Huang <jerry.huang@....com>, Leo Li <leoyang.li@....com>,
"ivan.khoronzhuk@...aro.org" <ivan.khoronzhuk@...aro.org>
Subject: RE: [EXT] Re: [v2,net-next] enetc: add support time specific
departure base on the qos etf
> -----Original Message-----
> From: David Miller <davem@...emloft.net>
> Sent: 2019年12月31日 12:27
> To: Po Liu <po.liu@....com>
> Cc: linux-kernel@...r.kernel.org; netdev@...r.kernel.org;
> vinicius.gomes@...el.com; Claudiu Manoil <claudiu.manoil@....com>;
> Vladimir Oltean <vladimir.oltean@....com>; Alexandru Marginean
> <alexandru.marginean@....com>; Xiaoliang Yang
> <xiaoliang.yang_1@....com>; Roy Zang <roy.zang@....com>; Mingkai Hu
> <mingkai.hu@....com>; Jerry Huang <jerry.huang@....com>; Leo Li
> <leoyang.li@....com>; ivan.khoronzhuk@...aro.org
> Subject: [EXT] Re: [v2,net-next] enetc: add support time specific departure base
> on the qos etf
>
> Caution: EXT Email
>
> From: Po Liu <po.liu@....com>
> Date: Fri, 27 Dec 2019 03:12:18 +0000
>
> > v2:
> > - fix the csum and time specific deaprture return directly if both
> > offloading enabled
>
> The test is in the wrong location.
>
> You are testing at run time when packets are being transmitted.
>
> Instead, you should test when the configuration change is made which creates
> the conflict, and disallow the configuration change in such a conflicting case.
Ok, thanks!
Br,
Po Liu
Powered by blists - more mailing lists