lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Thu, 2 Jan 2020 11:45:47 -0500 From: Neal Cardwell <ncardwell@...gle.com> To: Mao Wenan <maowenan@...wei.com> Cc: Eric Dumazet <edumazet@...gle.com>, David Miller <davem@...emloft.net>, Alexey Kuznetsov <kuznet@....inr.ac.ru>, Hideaki YOSHIFUJI <yoshfuji@...ux-ipv6.org>, Netdev <netdev@...r.kernel.org>, LKML <linux-kernel@...r.kernel.org>, kernel-janitors@...r.kernel.org, Yuchung Cheng <ycheng@...gle.com> Subject: Re: [PATCH net-next] tcp: use REXMIT_NEW instead of magic number On Thu, Jan 2, 2020 at 9:07 AM Mao Wenan <maowenan@...wei.com> wrote: > > REXMIT_NEW is a macro for "FRTO-style > transmit of unsent/new packets", this patch > makes it more readable. > > Signed-off-by: Mao Wenan <maowenan@...wei.com> > --- > net/ipv4/tcp_input.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/net/ipv4/tcp_input.c b/net/ipv4/tcp_input.c > index 88b987ca9ebb..1d1e3493965f 100644 > --- a/net/ipv4/tcp_input.c > +++ b/net/ipv4/tcp_input.c > @@ -3550,7 +3550,7 @@ static void tcp_xmit_recovery(struct sock *sk, int rexmit) > if (rexmit == REXMIT_NONE || sk->sk_state == TCP_SYN_SENT) > return; > > - if (unlikely(rexmit == 2)) { > + if (unlikely(rexmit == REXMIT_NEW)) { > __tcp_push_pending_frames(sk, tcp_current_mss(sk), > TCP_NAGLE_OFF); > if (after(tp->snd_nxt, tp->high_seq)) > -- Acked-by: Neal Cardwell <ncardwell@...gle.com> Thanks for sending this patch! neal
Powered by blists - more mailing lists