netdev - Re: [PATCH] net: dsa: mv88e6xxx: force cmode write on 6141/6341

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20200102.153159.1629304420356427596.davem@davemloft.net>
Date:   Thu, 02 Jan 2020 15:31:59 -0800 (PST)
From:   David Miller <davem@...emloft.net>
To:     andrew@...n.ch
Cc:     baruch@...s.co.il, vivien.didelot@...il.com, marek.behun@....cz,
        netdev@...r.kernel.org, d.odintsov@...viangames.com
Subject: Re: [PATCH] net: dsa: mv88e6xxx: force cmode write on 6141/6341

From: Andrew Lunn <andrew@...n.ch>
Date: Thu, 2 Jan 2020 23:36:41 +0100

> On Thu, Jan 02, 2020 at 12:45:56PM -0800, David Miller wrote:
>> From: Baruch Siach <baruch@...s.co.il>
>> Date: Thu, 19 Dec 2019 11:48:22 +0200
>> 
>> > mv88e6xxx_port_set_cmode() relies on cmode stored in struct
>> > mv88e6xxx_port to skip cmode update when the requested value matches the
>> > cached value. It turns out that mv88e6xxx_port_hidden_write() might
>> > change the port cmode setting as a side effect, so we can't rely on the
>> > cached value to determine that cmode update in not necessary.
>> > 
>> > Force cmode update in mv88e6341_port_set_cmode(), to make
>> > serdes configuration work again. Other mv88e6xxx_port_set_cmode()
>> > callers keep the current behaviour.
>> > 
>> > This fixes serdes configuration of the 6141 switch on SolidRun Clearfog
>> > GT-8K.
>> > 
>> > Fixes: 7a3007d22e8 ("net: dsa: mv88e6xxx: fully support SERDES on Topaz family")
>> > Reported-by: Denis Odintsov <d.odintsov@...viangames.com>
>> > Signed-off-by: Baruch Siach <baruch@...s.co.il>
>> 
>> This thread has stalled on December 20th with Baruch asking if we can put this
>> in for now as a temporary fix that solves the given problem whilst a better
>> long term analysis and change is being worked on.
> 
> Hi David
> 
> It seems like a reasonable fix for the moment.
> 
> Reviewed-by: Andrew Lunn <andrew@...n.ch>

Thanks Andrew.

Applied and queued up for -stable.