netdev - [PATCH INTERNAL v2] firmware: tee_bnxt: Fix multiple call to tee_client_close

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [thread-next>] [day] [month] [year] [list]

Message-Id: <1578068404-26195-1-git-send-email-vikas.gupta@broadcom.com>
Date:   Fri,  3 Jan 2020 21:50:03 +0530
From:   Vikas Gupta <vikas.gupta@...adcom.com>
To:     Rafał Miłecki <zajec5@...il.com>,
        "David S. Miller" <davem@...emloft.net>,
        Sheetal Tigadoli <sheetal.tigadoli@...adcom.com>,
        netdev@...r.kernel.org, linux-mips@...r.kernel.org,
        linux-kernel@...r.kernel.org, Sumit Garg <sumit.garg@...aro.org>
Cc:     vasundhara-v.volam@...adcom.com, vikram.prakash@...adcom.com,
        Vikas Gupta <vikas.gupta@...adcom.com>
Subject: [PATCH INTERNAL v2] firmware: tee_bnxt: Fix multiple call to tee_client_close_context

Fix calling multiple tee_client_close_context in case of shm allocation
fails.

Fixes: 246880958ac9 (“firmware: broadcom: add OP-TEE based BNXT f/w manager”)
Signed-off-by: Vikas Gupta <vikas.gupta@...adcom.com>
---
 drivers/firmware/broadcom/tee_bnxt_fw.c | 1 -
 1 file changed, 1 deletion(-)

diff --git a/drivers/firmware/broadcom/tee_bnxt_fw.c b/drivers/firmware/broadcom/tee_bnxt_fw.c
index 5b7ef89..ed10da5 100644
--- a/drivers/firmware/broadcom/tee_bnxt_fw.c
+++ b/drivers/firmware/broadcom/tee_bnxt_fw.c
@@ -215,7 +215,6 @@ static int tee_bnxt_fw_probe(struct device *dev)
 	fw_shm_pool = tee_shm_alloc(pvt_data.ctx, MAX_SHM_MEM_SZ,
 				    TEE_SHM_MAPPED | TEE_SHM_DMA_BUF);
 	if (IS_ERR(fw_shm_pool)) {
-		tee_client_close_context(pvt_data.ctx);
 		dev_err(pvt_data.dev, "tee_shm_alloc failed\n");
 		err = PTR_ERR(fw_shm_pool);
 		goto out_sess;
-- 
2.7.4