netdev - Re: [PATCH] sch_cake: avoid possible divide by zero in cake

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20200102.163507.404343273086201773.davem@davemloft.net>
Date:   Thu, 02 Jan 2020 16:35:07 -0800 (PST)
From:   David Miller <davem@...emloft.net>
To:     wenyang@...ux.alibaba.com
Cc:     toke@...e.dk, ldir@...byshire-bryant.me.uk, toke@...hat.com,
        xiyou.wangcong@...il.com, cake@...ts.bufferbloat.net,
        netdev@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] sch_cake: avoid possible divide by zero in
 cake_enqueue()

From: Wen Yang <wenyang@...ux.alibaba.com>
Date: Thu,  2 Jan 2020 17:21:43 +0800

> The variables 'window_interval' is u64 and do_div()
> truncates it to 32 bits, which means it can test
> non-zero and be truncated to zero for division.
> The unit of window_interval is nanoseconds,
> so its lower 32-bit is relatively easy to exceed.
> Fix this issue by using div64_u64() instead.
> 
> Fixes: 7298de9cd725 ("sch_cake: Add ingress mode")
> Signed-off-by: Wen Yang <wenyang@...ux.alibaba.com>

Applied and queued up for -stable.