netdev - Re: [PATCH net] net: phylink: fix failure to register on x86 systems

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Fri, 3 Jan 2020 10:45:06 -0800
From:   Florian Fainelli <f.fainelli@...il.com>
To:     Russell King <rmk+kernel@...linux.org.uk>,
        Andrew Lunn <andrew@...n.ch>,
        Heiner Kallweit <hkallweit1@...il.com>
Cc:     "David S. Miller" <davem@...emloft.net>, netdev@...r.kernel.org
Subject: Re: [PATCH net] net: phylink: fix failure to register on x86 systems

On 1/3/20 7:13 AM, Russell King wrote:
> The kernel test robot reports a boot failure with qemu in 5.5-rc,
> referencing commit 2203cbf2c8b5 ("net: sfp: move fwnode parsing into
> sfp-bus layer"). This is caused by phylink_create() being passed a
> NULL fwnode, causing fwnode_property_get_reference_args() to return
> -EINVAL.
> 
> Don't attempt to attach to a SFP bus if we have no fwnode, which
> avoids this issue.
> 
> Reported-by: kernel test robot <rong.a.chen@...el.com>
> Fixes: 2203cbf2c8b5 ("net: sfp: move fwnode parsing into sfp-bus layer")
> Signed-off-by: Russell King <rmk+kernel@...linux.org.uk>

Reviewed-by: Florian Fainelli <f.fainelli@...il.com>
-- 
Florian