netdev - Re: [PATCH] net: Correct type of tcp

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20200103080144.GC12930@netronome.com>
Date:   Fri, 3 Jan 2020 09:01:45 +0100
From:   Simon Horman <simon.horman@...ronome.com>
To:     David Miller <davem@...emloft.net>
Cc:     netdev@...r.kernel.org
Subject: Re: [PATCH] net: Correct type of tcp_syncookies sysctl.

On Thu, Jan 02, 2020 at 04:08:18PM -0800, David Miller wrote:
> 
> It can take on the values of '0', '1', and '2' and thus
> is not a boolean.
> 
> Signed-off-by: David S. Miller <davem@...emloft.net>

Reviewed-by: Simon Horman <simon.horman@...ronome.com>

> ---
>  Documentation/networking/ip-sysctl.txt | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> Applied and pushed out to 'net'.
> 
> diff --git a/Documentation/networking/ip-sysctl.txt b/Documentation/networking/ip-sysctl.txt
> index fd26788e8c96..48ccb1b31160 100644
> --- a/Documentation/networking/ip-sysctl.txt
> +++ b/Documentation/networking/ip-sysctl.txt
> @@ -603,7 +603,7 @@ tcp_synack_retries - INTEGER
>  	with the current initial RTO of 1second. With this the final timeout
>  	for a passive TCP connection will happen after 63seconds.
>  
> -tcp_syncookies - BOOLEAN
> +tcp_syncookies - INTEGER
>  	Only valid when the kernel was compiled with CONFIG_SYN_COOKIES
>  	Send out syncookies when the syn backlog queue of a socket
>  	overflows. This is to prevent against the common 'SYN flood attack'
> -- 
> 2.20.1
>