netdev - Re: [PATCH] Fixing coding style. Signed-off-by: amritapatole@...il.com

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20200103132506.GK3911@kadam>
Date:   Fri, 3 Jan 2020 16:25:49 +0300
From:   Dan Carpenter <dan.carpenter@...cle.com>
To:     Amrita Patole <longlivelinux@...oo.com>
Cc:     Greg KH <gregkh@...uxfoundation.org>, devel@...verdev.osuosl.org,
        GR-Linux-NIC-Dev@...vell.com, manishc@...vell.com,
        Amrita Patole <amritapatole@...il.com>, netdev@...r.kernel.org,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH] Fixing coding style. Signed-off-by:
 amritapatole@...il.com

On Thu, Jan 02, 2020 at 12:16:53PM +0100, Greg KH wrote:
> On Thu, Jan 02, 2020 at 12:59:29PM +0530, Amrita Patole wrote:
> > From: Amrita Patole <amritapatole@...il.com>
> > 
> > ---
> >  drivers/staging/qlge/qlge_mpi.c | 3 ++-
> >  1 file changed, 2 insertions(+), 1 deletion(-)
> > 
> > diff --git a/drivers/staging/qlge/qlge_mpi.c b/drivers/staging/qlge/qlge_mpi.c
> > index 9e422bbbb6ab..f63db2c79fac 100644
> > --- a/drivers/staging/qlge/qlge_mpi.c
> > +++ b/drivers/staging/qlge/qlge_mpi.c
> > @@ -136,7 +136,8 @@ static int ql_get_mb_sts(struct ql_adapter *qdev, struct mbox_params *mbcp)
> >  		    ql_read_mpi_reg(qdev, qdev->mailbox_out + i,
> >  				     &mbcp->mbox_out[i]);
> >  		if (status) {
> > -			netif_err(qdev, drv, qdev->ndev, "Failed mailbox read.\n");
> > +			netif_err(qdev, drv, qdev->ndev,
> > +                                  "Failed mailbox read. \n");


			netif_err(qdev, drv, qdev->ndev,
                                  "Failed mailbox read. \n");
				  "Failed mailbox read. \n");


I'm pretty sure this will introduce a couplee new checkpatch warnings...
It should be indented:
[tab][tab][tab][tab][space][space]"Failed mailbox read.\n");

No space after the period, please.

regards,
dan carpenter