netdev - Re: [PATCH 5/8] net: bluetooth: remove unneeded MODULE

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Sun, 5 Jan 2020 11:42:16 +0100
From:   Greg KH <greg@...ah.com>
To:     Marcel Holtmann <marcel@...tmann.org>
Cc:     "Enrico Weigelt, metux IT consult" <info@...ux.net>,
        lkml <linux-kernel@...r.kernel.org>,
        "David S. Miller" <davem@...emloft.net>,
        mareklindner@...mailbox.ch, sw@...onwunderlich.de, a@...table.cc,
        sven@...fation.org, Johan Hedberg <johan.hedberg@...il.com>,
        roopa@...ulusnetworks.com, nikolay@...ulusnetworks.com,
        edumazet@...gle.com, kuznet@....inr.ac.ru, yoshfuji@...ux-ipv6.org,
        jon.maloy@...csson.com, ying.xue@...driver.com, kafai@...com,
        songliubraving@...com, yhs@...com, andriin@...com,
        netdev <netdev@...r.kernel.org>,
        BlueZ devel list <linux-bluetooth@...r.kernel.org>,
        tipc-discussion@...ts.sourceforge.net,
        linux-hyperv@...r.kernel.org, bpf@...r.kernel.org
Subject: Re: [PATCH 5/8] net: bluetooth: remove unneeded MODULE_VERSION()
 usage

On Sun, Jan 05, 2020 at 10:34:56AM +0100, Marcel Holtmann wrote:
> Hi Enrico,
> 
> > Remove MODULE_VERSION(), as it isn't needed at all: the only version
> > making sense is the kernel version.
> 
> I prefer to keep the MODULE_VERSION info since it provides this
> information via modinfo.

Sure, but it's really pointless :)

> Unless there is a kernel wide consent to remove MODULE_VERSION
> altogether, the Bluetooth subsystem is keeping it.

I've deleted them from lots of drivers/subsystems already as they do not
make any sense when you think about vendor kernels, stable kernels, and
upstream kernel versions.

thanks,

greg k-h