netdev - Re: [PATCH v4 net-next 0/2] ionic: add sriov support

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Sun, 05 Jan 2020 14:51:16 -0800 (PST)
From:   David Miller <davem@...emloft.net>
To:     snelson@...sando.io
Cc:     netdev@...r.kernel.org, parav@...lanox.com
Subject: Re: [PATCH v4 net-next 0/2] ionic: add sriov support

From: Shannon Nelson <snelson@...sando.io>
Date: Fri,  3 Jan 2020 09:55:06 -0800

> Set up the basic support for enabling SR-IOV devices in the
> ionic driver.  Since most of the management work happens in
> the NIC firmware, the driver becomes mostly a pass-through
> for the network stack commands that want to control and
> configure the VFs.
> 
> v4:	changed "vf too big" checks to use pci_num_vf()
> 	changed from vf[] array of pointers of individually allocated
> 	  vf structs to single allocated vfs[] array of vf structs
> 	added clean up of vfs[] on probe fail
> 	added setup for vf stats dma
> 
> v3:	added check in probe for pre-existing VFs
> 	split out the alloc and dealloc of vf structs to better deal
> 	  with pre-existing VFs (left enabled on remove)
> 	restored the checks for vf too big because of a potential
> 	  case where VFs are already enabled but driver failed to
> 	  alloc the vf structs
> 
> v2:	use pci_num_vf() and kcalloc()
> 	remove checks for vf too big
> 	add locking for the VF operations
> 	disable VFs in ionic_remove() if they are still running

Series applied, thanks Shannon.