netdev - Re: [PATCH net-next 0/5] Unique mv88e6xxx IRQ names

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAFXsbZrTYjhvja4+-X9hmWGX1-GShXt_SmjgRydN1OTmGS+xmQ@mail.gmail.com>
Date:   Mon, 6 Jan 2020 12:03:08 -0800
From:   Chris Healy <cphealy@...il.com>
To:     Andrew Lunn <andrew@...n.ch>
Cc:     David Miller <davem@...emloft.net>,
        netdev <netdev@...r.kernel.org>,
        Vivien Didelot <vivien.didelot@...il.com>
Subject: Re: [PATCH net-next 0/5] Unique mv88e6xxx IRQ names

Series is:

Tested-by: Chris Healy <cphealy@...il.com>

On Mon, Jan 6, 2020 at 8:14 AM Andrew Lunn <andrew@...n.ch> wrote:
>
> There are a few boards which have multiple mv88e6xxx switches. With
> such boards, it can be hard to determine which interrupts belong to
> which switches. Make the interrupt names unique by including the
> device name in the interrupt name. For the SERDES interrupt, also
> include the port number. As a result of these patches ZII devel C
> looks like:
>
>  50:          0  gpio-vf610  27 Level     mv88e6xxx-0.1:00
>  54:          0  mv88e6xxx-g1   3 Edge      mv88e6xxx-0.1:00-g1-atu-prob
>  56:          0  mv88e6xxx-g1   5 Edge      mv88e6xxx-0.1:00-g1-vtu-prob
>  58:          0  mv88e6xxx-g1   7 Edge      mv88e6xxx-0.1:00-g2
>  61:          0  mv88e6xxx-g2   1 Edge      !mdio-mux!mdio@...witch@...dio:01
>  62:          0  mv88e6xxx-g2   2 Edge      !mdio-mux!mdio@...witch@...dio:02
>  63:          0  mv88e6xxx-g2   3 Edge      !mdio-mux!mdio@...witch@...dio:03
>  64:          0  mv88e6xxx-g2   4 Edge      !mdio-mux!mdio@...witch@...dio:04
>  70:          0  mv88e6xxx-g2  10 Edge      mv88e6xxx-0.1:00-serdes-10
>  75:          0  mv88e6xxx-g2  15 Edge      mv88e6xxx-0.1:00-watchdog
>  76:          5  gpio-vf610  26 Level     mv88e6xxx-0.2:00
>  80:          0  mv88e6xxx-g1   3 Edge      mv88e6xxx-0.2:00-g1-atu-prob
>  82:          0  mv88e6xxx-g1   5 Edge      mv88e6xxx-0.2:00-g1-vtu-prob
>  84:          4  mv88e6xxx-g1   7 Edge      mv88e6xxx-0.2:00-g2
>  87:          2  mv88e6xxx-g2   1 Edge      !mdio-mux!mdio@...witch@...dio:01
>  88:          0  mv88e6xxx-g2   2 Edge      !mdio-mux!mdio@...witch@...dio:02
>  89:          0  mv88e6xxx-g2   3 Edge      !mdio-mux!mdio@...witch@...dio:03
>  90:          0  mv88e6xxx-g2   4 Edge      !mdio-mux!mdio@...witch@...dio:04
>  95:          3  mv88e6xxx-g2   9 Edge      mv88e6xxx-0.2:00-serdes-9
>  96:          0  mv88e6xxx-g2  10 Edge      mv88e6xxx-0.2:00-serdes-10
> 101:          0  mv88e6xxx-g2  15 Edge      mv88e6xxx-0.2:00-watchdog
>
> Interrupt names like !mdio-mux!mdio@...witch@...dio:01 are created by
> phylib for the integrated PHYs. The mv88e6xxx driver does not
> determine these names.
>
> Andrew Lunn (5):
>   net: dsa: mv88e6xxx: Unique IRQ name
>   net: dsa: mv88e6xxx: Unique SERDES interrupt names
>   net: dsa: mv88e6xxx: Unique watchdog IRQ name
>   net: dsa: mv88e6xxx: Unique g2 IRQ name
>   net: dsa: mv88e6xxx: Unique ATU and VTU IRQ names
>
>  drivers/net/dsa/mv88e6xxx/chip.c        | 11 +++++++++--
>  drivers/net/dsa/mv88e6xxx/chip.h        |  6 ++++++
>  drivers/net/dsa/mv88e6xxx/global1_atu.c |  5 ++++-
>  drivers/net/dsa/mv88e6xxx/global1_vtu.c |  5 ++++-
>  drivers/net/dsa/mv88e6xxx/global2.c     | 10 ++++++++--
>  5 files changed, 31 insertions(+), 6 deletions(-)
>
> --
> 2.25.0.rc1
>