netdev - Re: [PATCH 1/2] net: ethernet: 3c515: Fix cast from pointer to integer of different size

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Mon, 06 Jan 2020 13:31:55 -0800 (PST)
From:   David Miller <davem@...hat.com>
To:     krzk@...nel.org
Cc:     netdev@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH 1/2] net: ethernet: 3c515: Fix cast from pointer to
 integer of different size

From: Krzysztof Kozlowski <krzk@...nel.org>
Date: Sat,  4 Jan 2020 15:33:05 +0100

> Pointer passed as integer should be cast to unsigned long to
> avoid warning (compile testing on alpha architecture):
> 
>     drivers/net/ethernet/3com/3c515.c: In function ‘corkscrew_start_xmit’:
>     drivers/net/ethernet/3com/3c515.c:1066:8: warning:
>         cast from pointer to integer of different size [-Wpointer-to-int-cast]
> 
> Signed-off-by: Krzysztof Kozlowski <krzk@...nel.org>
> 
> ---
> 
> Only compile tested

Sorry, I'm not applying these two.

It is clear that these drivers only work properly on 32-bit architectures
where virtual address equals the DMA address.

Making this warning goes away creates a false sense that they are in
fact 64-bit clean and capable, they are not.