netdev - Re: [PATCH net-next 9/9 v3] net: ethernet: ixp4xx: Use parent dev for DMA pool

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CACRpkdagGWBcQz8mVj9OqH+xL_tr1hbVv7sTnJ9GeLVq0dRamw@mail.gmail.com>
Date:   Mon, 6 Jan 2020 23:39:19 +0100
From:   Linus Walleij <linus.walleij@...aro.org>
To:     David Miller <davem@...hat.com>
Cc:     netdev <netdev@...r.kernel.org>, Arnd Bergmann <arnd@...db.de>,
        Jakub Kicinski <jakub.kicinski@...ronome.com>,
        stable <stable@...r.kernel.org>
Subject: Re: [PATCH net-next 9/9 v3] net: ethernet: ixp4xx: Use parent dev for
 DMA pool

On Mon, Jan 6, 2020 at 11:01 PM David Miller <davem@...hat.com> wrote:
> From: Linus Walleij <linus.walleij@...aro.org>
> Date: Mon,  6 Jan 2020 08:46:47 +0100
>
> > Use the netdevice struct device .parent field when calling
> > dma_pool_create(): the .dma_coherent_mask and .dma_mask
> > pertains to the bus device on the hardware (platform)
> > bus in this case, not the struct device inside the network
> > device. This makes the pool allocation work.
> >
> > Cc: stable@...r.kernel.org
> > Signed-off-by: Linus Walleij <linus.walleij@...aro.org>
>
> Networking changes don't use CC:'ing stable, please see the netdev
> FAQ under Documentation/

Oh yeah I actually knew that now, just that the patch was written
before I knew and I missed that was still in there.

> If you want to submit this bug fix, submit to 'net' and provide an
> appropriate Fixes: tag.

It's no big deal so let's skip that, do you want me to resend the lot
or can you just strip the stable tag when applying?

Yours,
Linus Walleij