netdev - Re: [PATCH] stmmac: debugfs entry name is not be changed when udev rename device name.

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <dd27bae8-46d0-6802-90b9-475d8489d528@windriver.com>
Date:   Mon, 6 Jan 2020 09:30:53 +0800
From:   Jiping Ma <Jiping.Ma2@...driver.com>
To:     David Miller <davem@...emloft.net>
CC:     <peppe.cavallaro@...com>, <alexandre.torgue@...com>,
        <joabreu@...opsys.com>, <mcoquelin.stm32@...il.com>,
        <netdev@...r.kernel.org>, <linux-arm-kernel@...ts.infradead.org>,
        <linux-stm32@...md-mailman.stormreply.com>,
        <linux-kernel@...r.kernel.org>, ytao <yue.tao@...driver.com>
Subject: Re: [PATCH] stmmac: debugfs entry name is not be changed when udev
 rename device name.



On 01/05/2020 12:18 PM, David Miller wrote:
> From: Jiping Ma <jiping.ma2@...driver.com>
> Date: Thu, 2 Jan 2020 09:35:44 +0800
>
>> Add one notifier for udev changes net device name.
>>
>> Signed-off-by: Jiping Ma <jiping.ma2@...driver.com>
>> ---
>>   .../net/ethernet/stmicro/stmmac/stmmac_main.c | 28 +++++++++++++++++++
>>   1 file changed, 28 insertions(+)
>>
>> diff --git a/drivers/net/ethernet/stmicro/stmmac/stmmac_main.c b/drivers/net/ethernet/stmicro/stmmac/stmmac_main.c
>> index b14f46a57154..3b05cb80eed7 100644
>> --- a/drivers/net/ethernet/stmicro/stmmac/stmmac_main.c
>> +++ b/drivers/net/ethernet/stmicro/stmmac/stmmac_main.c
>> @@ -4038,6 +4038,31 @@ static int stmmac_dma_cap_show(struct seq_file *seq, void *v)
>>   }
>>   DEFINE_SHOW_ATTRIBUTE(stmmac_dma_cap);
>>   
>> +/* Use network device events to rename debugfs file entries.
>> + */
>> +static int stmmac_device_event(struct notifier_block *unused,
>> +			       unsigned long event, void *ptr)
>> +{
>> +	struct net_device *dev = netdev_notifier_info_to_dev(ptr);
>> +	struct stmmac_priv *priv = netdev_priv(dev);
>> +
>> +	switch (event) {
>> +	case NETDEV_CHANGENAME:
> This notifier gets called for every single netdevice in the entire
> system.
>
> You cannot just assume that the device that gets passed in here is
> an stmmac device.
>
> Look at how other drivers handle this to see how to do it correctly.
>
> Thank you.
Thanks to remind.  I will modify it and send it review again.
>