netdev - Re: [PATCH] gtp: simplify error handling code in 'gtp_encap

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20200106085943.GB10460@netronome.com>
Date:   Mon, 6 Jan 2020 09:59:43 +0100
From:   Simon Horman <simon.horman@...ronome.com>
To:     Christophe JAILLET <christophe.jaillet@...adoo.fr>
Cc:     pablo@...filter.org, laforge@...monks.org, davem@...emloft.net,
        osmocom-net-gprs@...ts.osmocom.org, netdev@...r.kernel.org,
        linux-kernel@...r.kernel.org, kernel-janitors@...r.kernel.org
Subject: Re: [PATCH] gtp: simplify error handling code in 'gtp_encap_enable()'

On Sun, Jan 05, 2020 at 06:36:07PM +0100, Christophe JAILLET wrote:
> 'gtp_encap_disable_sock(sk)' handles the case where sk is NULL, so there
> is no need to test it before calling the function.
> 
> This saves a few line of code.
> 
> Signed-off-by: Christophe JAILLET <christophe.jaillet@...adoo.fr>

Reviewed-by: Simon Horman <simon.horman@...ronome.com>