netdev - Re: [PATCH] net: 3com: 3c59x: remove set but not used variable 'mii

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <983f869c-5638-8f77-d404-e1164e34f73f@huawei.com>
Date:   Mon, 6 Jan 2020 20:48:33 +0800
From:   "yukuai (C)" <yukuai3@...wei.com>
To:     Andrew Lunn <andrew@...n.ch>,
        Florian Fainelli <f.fainelli@...il.com>
CC:     Vladimir Oltean <olteanv@...il.com>,
        Matthew Wilcox <willy@...radead.org>, <klassert@...nel.org>,
        "David S. Miller" <davem@...emloft.net>,
        "Heiner Kallweit" <hkallweit1@...il.com>,
        Jakub Kicinski <jakub.kicinski@...ronome.com>,
        <hslester96@...il.com>, <mst@...hat.com>, <yang.wei9@....com.cn>,
        netdev <netdev@...r.kernel.org>,
        lkml <linux-kernel@...r.kernel.org>, <yi.zhang@...wei.com>,
        <zhengbin13@...wei.com>
Subject: Re: [PATCH] net: 3com: 3c59x: remove set but not used variable
 'mii_reg1'

On 2020/1/4 3:37, Andrew Lunn wrote:
>> And since more reviewers are on the same boat, the fix should probably
>> look to eliminate the warning by doing something like:
>>
>> (void)mdio_read(dev, vp->phys[0], MII_BMSR);
> 
> Yes, this is the safe option.
> 
>       Andrew
> 
> .
Thank you all for your response!

Yu Kuai