netdev - Re: [PATCH net-next 2/4] ionic: fix for ppc msix layout

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20200106.184216.2300076228313231081.davem@davemloft.net>
Date:   Mon, 06 Jan 2020 18:42:16 -0800 (PST)
From:   David Miller <davem@...emloft.net>
To:     snelson@...sando.io
Cc:     netdev@...r.kernel.org
Subject: Re: [PATCH net-next 2/4] ionic: fix for ppc msix layout

From: Shannon Nelson <snelson@...sando.io>
Date: Mon,  6 Jan 2020 13:05:10 -0800

> The IBM Power9 ppc64 seems to have a problem with not wanting
> to limit the address space used by a PCI device.  The Naples
> internal HW can only address up to 52 bits, but the ppc does
> not play well with that limitation.  This patch tells the
> system how to work with Naples successfully.
> 
> Signed-off-by: Shannon Nelson <snelson@...sando.io>

Then dma_set_mask_and_coherent() should fail, either that or the mask
being passed in isn't correct.

There is no reason this hack should be necessary in any driver.

Our DMA abstractions are built to handle exactly this kind of
situation.

Please find out what is really going on and fix this properly.

Thank you.