lists.openwall.net   lists  /  announce  owl-users  owl-dev  john-users  john-dev  passwdqc-users  yescrypt  popa3d-users  /  oss-security  kernel-hardening  musl  sabotage  tlsify  passwords  /  crypt-dev  xvendor  /  Bugtraq  Full-Disclosure  linux-kernel  linux-netdev  linux-ext4  linux-hardening  PHC 
Open Source and information security mailing list archives
 
Hash Suite: Windows password security audit tool. GUI, reports in PDF.
[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Date:   Wed, 8 Jan 2020 13:25:21 +0000
From:   Jose Abreu <Jose.Abreu@...opsys.com>
To:     Dejin Zheng <zhengdejin5@...il.com>
CC:     "peppe.cavallaro@...com" <peppe.cavallaro@...com>,
        "alexandre.torgue@...com" <alexandre.torgue@...com>,
        "davem@...emloft.net" <davem@...emloft.net>,
        "mcoquelin.stm32@...il.com" <mcoquelin.stm32@...il.com>,
        "martin.blumenstingl@...glemail.com" 
        <martin.blumenstingl@...glemail.com>,
        "treding@...dia.com" <treding@...dia.com>,
        "andrew@...n.ch" <andrew@...n.ch>,
        "weifeng.voon@...el.com" <weifeng.voon@...el.com>,
        "tglx@...utronix.de" <tglx@...utronix.de>,
        "netdev@...r.kernel.org" <netdev@...r.kernel.org>,
        "linux-stm32@...md-mailman.stormreply.com" 
        <linux-stm32@...md-mailman.stormreply.com>,
        "linux-arm-kernel@...ts.infradead.org" 
        <linux-arm-kernel@...ts.infradead.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: RE: [PATCH v2 0/2] net: stmmac: remove useless code of phy_mask

From: Dejin Zheng <zhengdejin5@...il.com>
Date: Jan/08/2020, 11:26:52 (UTC+00:00)

> On Wed, Jan 08, 2020 at 07:57:14AM +0000, Jose Abreu wrote:
> > From: Dejin Zheng <zhengdejin5@...il.com>
> > Date: Jan/08/2020, 07:25:48 (UTC+00:00)
> > 
> > > Changes since v1:
> > > 	1, add a new commit for remove the useless member phy_mask.
> > 
> > No, this is not useless. It's an API for developers that need only 
> > certain PHYs to be detected. Please do not remove this.
> >
> Hi Jose:
> 
> Okay, If you think it is a feature that needs to be retained, I will
> abandon it. since I am a newbie, after that, Do I need to update the
> other commit in this patchset for patch v3? Thanks!

Your first commit (1/2) looks okay so you can submit that stand-alone in 
my opinion.

---
Thanks,
Jose Miguel Abreu

Powered by blists - more mailing lists