netdev - Re: [RFC] obsolete references to Documentation/devicetree/bindings/net/ethernet.txt

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Wed, 8 Jan 2020 10:24:43 -0600
From:   Rob Herring <robh@...nel.org>
To:     Andrew Lunn <andrew@...n.ch>,
        "Madalin Bucur (OSS)" <madalin.bucur@....nxp.com>
Cc:     "maxime.ripard@...tlin.com" <maxime.ripard@...tlin.com>,
        "mark.rutland@....com" <mark.rutland@....com>,
        "devicetree@...r.kernel.org" <devicetree@...r.kernel.org>,
        "netdev@...r.kernel.org" <netdev@...r.kernel.org>
Subject: Re: [RFC] obsolete references to
 Documentation/devicetree/bindings/net/ethernet.txt

On Thu, Dec 26, 2019 at 12:08:21PM +0100, Andrew Lunn wrote:
> On Mon, Dec 23, 2019 at 09:00:50AM +0000, Madalin Bucur (OSS) wrote:
> > Hi,
> > 
> > this patch removed the ethernet.txt content and added the information found in
> > it in the ethernet-controller.yaml (Documentation/devicetree/bindings/net):
> > 
> >   commit 9d3de3c58347623b5e71d554628a1571cd3142ad
> >   Author: Maxime Ripard <maxime.ripard@...tlin.com>
> >   Date:   Thu Jun 27 17:31:43 2019 +0200
> > 
> >       dt-bindings: net: Add YAML schemas for the generic Ethernet options
> > 
> >       The Ethernet controllers have a good number of generic options that can be
> >       needed in a device tree. Add a YAML schemas for those.
> > 
> >       Reviewed-by: Rob Herring <robh@...nel.org>
> >       Signed-off-by: Maxime Ripard <maxime.ripard@...tlin.com>
> >       Reviewed-by: Andrew Lunn <andrew@...n.ch>
> >       Signed-off-by: Rob Herring <robh@...nel.org>
> > 
> > There are still many references to the previous ethernet.txt document:
> > 
> >   $ grep ethernet.txt Documentation/devicetree/bindings/net/ -r | wc -l
> >   96
> > 
> > Should those be updated too or it's enough to rely on the current content
> > of the previous ethernet.txt file:
> > 
> >   $ cat Documentation/devicetree/bindings/net/ethernet.txt
> >   This file has moved to ethernet-controller.yaml.

If this wasn't enough, we wouldn't have put that there.

> 
> Hi Madalin
> 
> Feel free to fix the references if you want. Probably a perl one liner
> should do most of the work.

The above was done to avoid some churn. The real fix is convert bindings 
to DT schema. The references should get dropped as part of that.

Rob