netdev - Re: [PATCH] bpf/sockmap: read psock ingress_msg before sk_receive

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAPhsuW4457A1JKrPJSjdabbRAPBo1qucrnSirnYkM868zp9VKw@mail.gmail.com>
Date:   Wed, 8 Jan 2020 08:50:56 -0800
From:   Song Liu <song@...nel.org>
To:     Lingpeng Chen <forrest0579@...il.com>
Cc:     John Fastabend <john.fastabend@...il.com>,
        Daniel Borkmann <daniel@...earbox.net>,
        Networking <netdev@...r.kernel.org>, bpf <bpf@...r.kernel.org>
Subject: Re: [PATCH] bpf/sockmap: read psock ingress_msg before sk_receive_queue

On Tue, Jan 7, 2020 at 8:58 PM Lingpeng Chen <forrest0579@...il.com> wrote:
>
> Right now in tcp_bpf_recvmsg, sock read data first from sk_receive_queue
> if not empty than psock->ingress_msg otherwise. If a FIN packet arrives
> and there's also some data in psock->ingress_msg, the data in
> psock->ingress_msg will be purged. It is always happen when request to a
> HTTP1.0 server like python SimpleHTTPServer since the server send FIN
> packet after data is sent out.
>
> Fixes: 604326b41a6fb ("bpf, sockmap: convert to generic sk_msg interface")
> Reported-by: Arika Chen <eaglesora@...il.com>
> Suggested-by: Arika Chen <eaglesora@...il.com>
> Signed-off-by: Lingpeng Chen <forrest0579@...il.com>
> Signed-off-by: John Fastabend <john.fastabend@...il.com>

Cc: stable@...r.kernel.org # v4.20+
Acked-by: Song Liu <songliubraving@...com>