netdev - Re: [PATCH bpf-next 2/6] libbpf: Collect static vs global info about functions

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <76F721B3-A848-40BD-8B1D-A0AA3EB1AB39@fb.com>
Date:   Wed, 8 Jan 2020 17:57:55 +0000
From:   Song Liu <songliubraving@...com>
To:     Toke Høiland-Jørgensen <toke@...hat.com>
CC:     Alexei Starovoitov <ast@...nel.org>,
        "davem@...emloft.net" <davem@...emloft.net>,
        "daniel@...earbox.net" <daniel@...earbox.net>,
        "netdev@...r.kernel.org" <netdev@...r.kernel.org>,
        "bpf@...r.kernel.org" <bpf@...r.kernel.org>,
        Kernel Team <Kernel-team@...com>
Subject: Re: [PATCH bpf-next 2/6] libbpf: Collect static vs global info about
 functions



> On Jan 8, 2020, at 2:25 AM, Toke Høiland-Jørgensen <toke@...hat.com> wrote:
> 
> Alexei Starovoitov <ast@...nel.org> writes:
> 
>> Collect static vs global information about BPF functions from ELF file and
>> improve BTF with this additional info if llvm is too old and doesn't emit it on
>> its own.
> 
> Has the support for this actually landed in LLVM yet? I tried grep'ing
> in the commit log and couldn't find anything...
> 
> [...]
>> @@ -313,6 +321,7 @@ struct bpf_object {
>> 	bool loaded;
>> 	bool has_pseudo_calls;
>> 	bool relaxed_core_relocs;
>> +	bool llvm_emits_func_linkage;
> 
> Nit: s/llvm/compiler/? Presumably GCC will also support this at some
> point?

Echoing this nit (and other references to llvm). Otherwise,

Acked-by: Song Liu <songliubraving@...com>