netdev - Re: [PATCH net-next 01/10] ipv4: Replace route in list before notifying

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <1d1ecb8e-e753-0f2c-7463-721d1aadee83@gmail.com>
Date:   Wed, 8 Jan 2020 11:33:45 -0700
From:   David Ahern <dsahern@...il.com>
To:     Ido Schimmel <idosch@...sch.org>, netdev@...r.kernel.org
Cc:     davem@...emloft.net, jiri@...lanox.com,
        jakub.kicinski@...ronome.com, roopa@...ulusnetworks.com,
        mlxsw@...lanox.com, Ido Schimmel <idosch@...lanox.com>
Subject: Re: [PATCH net-next 01/10] ipv4: Replace route in list before
 notifying

On 1/7/20 8:45 AM, Ido Schimmel wrote:
> From: Ido Schimmel <idosch@...lanox.com>
> 
> Subsequent patches will add an offload / trap indication to routes which
> will signal if the route is present in hardware or not.
> 
> After programming the route to the hardware, drivers will have to ask
> the IPv4 code to set the flags by passing the route's key.
> 
> In the case of route replace, the new route is notified before it is
> actually inserted into the FIB alias list. This can prevent simple
> drivers (e.g., netdevsim) that program the route to the hardware in the
> same context it is notified in from being able to set the flag.
> 
> Solve this by first inserting the new route to the list and rollback the
> operation in case the route was vetoed.
> 
> Signed-off-by: Ido Schimmel <idosch@...lanox.com>
> Reviewed-by: Jiri Pirko <jiri@...lanox.com>
> ---
>  net/ipv4/fib_trie.c | 11 +++++++----
>  1 file changed, 7 insertions(+), 4 deletions(-)
> 

Reviewed-by: David Ahern <dsahern@...il.com>