netdev - Re: [PATCH net-next] net: dsa: felix: fix link error

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CA+h21hqy6mK-Cy0VyXtDUtPqvqbTPGZ45aJ2eko+VQFzjDbtKg@mail.gmail.com>
Date:   Wed, 8 Jan 2020 20:51:01 +0200
From:   Vladimir Oltean <olteanv@...il.com>
To:     Arnd Bergmann <arnd@...db.de>
Cc:     "David S. Miller" <davem@...emloft.net>,
        Vladimir Oltean <vladimir.oltean@....com>,
        Claudiu Manoil <claudiu.manoil@....com>,
        netdev <netdev@...r.kernel.org>,
        lkml <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH net-next] net: dsa: felix: fix link error

Thanks Arnd!

On Wed, 8 Jan 2020 at 14:59, Arnd Bergmann <arnd@...db.de> wrote:
>
> When the enetc driver is disabled, the mdio support fails to
> get built:
>
> drivers/net/dsa/ocelot/felix_vsc9959.o: In function `vsc9959_mdio_bus_alloc':
> felix_vsc9959.c:(.text+0x19c): undefined reference to `enetc_hw_alloc'
> felix_vsc9959.c:(.text+0x1d1): undefined reference to `enetc_mdio_read'
> felix_vsc9959.c:(.text+0x1d8): undefined reference to `enetc_mdio_write'
>
> Change the Makefile to enter the subdirectory for this as well.
>
> Fixes: bdeced75b13f ("net: dsa: felix: Add PCS operations for PHYLINK")

I agree the patch is only seen with the commit you pointed to, but the
problem is also introduced by:

Fixes: 6517798dd343 ("enetc: Make MDIO accessors more generic and
export to include/linux/fsl")

[ please excuse me David, I don't know how to configure neither Gmail
nor Thunderbird to disable word wrapping ]

Reviewed-by: Vladimir Oltean <vladimir.oltean@....com>

> Signed-off-by: Arnd Bergmann <arnd@...db.de>
> ---
>  drivers/net/ethernet/freescale/Makefile | 1 +
>  1 file changed, 1 insertion(+)
>
> diff --git a/drivers/net/ethernet/freescale/Makefile b/drivers/net/ethernet/freescale/Makefile
> index 6a93293d31e0..67c436400352 100644
> --- a/drivers/net/ethernet/freescale/Makefile
> +++ b/drivers/net/ethernet/freescale/Makefile
> @@ -25,4 +25,5 @@ obj-$(CONFIG_FSL_DPAA_ETH) += dpaa/
>  obj-$(CONFIG_FSL_DPAA2_ETH) += dpaa2/
>
>  obj-$(CONFIG_FSL_ENETC) += enetc/
> +obj-$(CONFIG_FSL_ENETC_MDIO) += enetc/
>  obj-$(CONFIG_FSL_ENETC_VF) += enetc/
> --
> 2.20.0
>