netdev - Re: [PATCH net 0/2] When ungrafting from PRIO, replace child with FIFO

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Wed, 08 Jan 2020 12:47:36 -0800 (PST)
From:   David Miller <davem@...emloft.net>
To:     petrm@...lanox.com
Cc:     netdev@...r.kernel.org, jiri@...lanox.com
Subject: Re: [PATCH net 0/2] When ungrafting from PRIO, replace child with
 FIFO

From: Petr Machata <petrm@...lanox.com>
Date: Mon, 6 Jan 2020 18:01:53 +0000

> When a child Qdisc is removed from one of the PRIO Qdisc's bands, it is
> replaced unconditionally by a NOOP qdisc. As a result, any traffic hitting
> that band gets dropped. That is incorrect--no Qdisc was explicitly added
> when PRIO was created, and after removal, none should have to be added
> either.
> 
> In patch #2, this problem is fixed for PRIO by first attempting to create a
> default Qdisc and only falling back to noop when that fails. This pattern
> of attempting to create an invisible FIFO, using NOOP only as a fallback,
> is also seen in some other Qdiscs.
> 
> The only driver currently offloading PRIO (and thus presumably the only one
> impacted by this) is mlxsw. Therefore patch #1 extends mlxsw to handle the
> replacement by an invisible FIFO gracefully.

Series applied, and queued up for -stable, thanks!