netdev - Re: [PATCH] atm: eni: fix uninitialized variable warning

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20200108.131115.1879538107195635308.davem@davemloft.net>
Date:   Wed, 08 Jan 2020 13:11:15 -0800 (PST)
From:   David Miller <davem@...emloft.net>
To:     arnd@...db.de
Cc:     3chas3@...il.com, oleksandr@...hat.com, tglx@...utronix.de,
        gregkh@...uxfoundation.org, jonathan.lemon@...il.com,
        linux-atm-general@...ts.sourceforge.net, netdev@...r.kernel.org,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH] atm: eni: fix uninitialized variable warning

From: Arnd Bergmann <arnd@...db.de>
Date: Tue,  7 Jan 2020 21:43:59 +0100

> With -O3, gcc has found an actual unintialized variable stored
> into an mmio register in two instances:
> 
> drivers/atm/eni.c: In function 'discard':
> drivers/atm/eni.c:465:13: error: 'dma[1]' is used uninitialized in this function [-Werror=uninitialized]
>    writel(dma[i*2+1],eni_dev->rx_dma+dma_wr*8+4);
>              ^
> drivers/atm/eni.c:465:13: error: 'dma[3]' is used uninitialized in this function [-Werror=uninitialized]
> 
> Change the code to always write zeroes instead.
> 
> Signed-off-by: Arnd Bergmann <arnd@...db.de>

Applied.