netdev - [PATCH 0/8] reduce open coded skb->next access for gso segment walking

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [thread-next>] [day] [month] [year] [list]

Date:   Wed,  8 Jan 2020 16:59:01 -0500
From:   "Jason A. Donenfeld" <Jason@...c4.com>
To:     netdev@...r.kernel.org, davem@...emloft.net,
        siva.kallam@...adcom.com, christopher.lee@...i.com,
        ecree@...arflare.com, johannes.berg@...el.com
Cc:     "Jason A. Donenfeld" <Jason@...c4.com>
Subject: [PATCH 0/8] reduce open coded skb->next access for gso segment walking

This patchset introduces the skb_list_walk_safe helper macro, in order
to add some sanity to the myrid ways drivers have of walking through gso
segments. The goal is to reduce future bugs commonly caused by open
coding these sorts of things, and to in the future make it easier to
swap out the underlying list representation.

This first patch series addresses the easy uses of drivers iterating
over the returned list of skb_gso_segments, for drivers that live in
drivers/net/*. There are still other use cases to tackle later for
net/*, and after these low-hanging fruits are taken care of, I imagine
there are more subtle cases of gso segment walking that isn't just a
direct return value from skb_gso_segments, and eventually this will have
to be tackled. This series is the first in that direction.

Jason A. Donenfeld (8):
  net: introduce skb_list_walk_safe for skb segment walking
  net: tap: use skb_list_walk_safe helper for gso segments
  net: r8152: use skb_list_walk_safe helper for gso segments
  net: tg3: use skb_list_walk_safe helper for gso segments
  net: sunvnet: use skb_list_walk_safe helper for gso segments
  net: sfc: use skb_list_walk_safe helper for gso segments
  net: myri10ge: use skb_list_walk_safe helper for gso segments
  net: iwlwifi: use skb_list_walk_safe helper for gso segments

 drivers/net/ethernet/broadcom/tg3.c              | 12 +++++-------
 drivers/net/ethernet/myricom/myri10ge/myri10ge.c |  8 +++-----
 drivers/net/ethernet/sfc/tx.c                    |  7 ++-----
 drivers/net/ethernet/sun/sunvnet_common.c        |  9 +++------
 drivers/net/tap.c                                | 14 ++++++--------
 drivers/net/usb/r8152.c                          | 12 +++++-------
 drivers/net/wireguard/device.h                   |  8 --------
 drivers/net/wireless/intel/iwlwifi/mvm/tx.c      |  9 ++-------
 include/linux/skbuff.h                           |  5 +++++
 9 files changed, 31 insertions(+), 53 deletions(-)

-- 
2.24.1