netdev - RE: [PATCH] gianfar: Solve ethernet TX/RX problems for ls1021a

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <HK0PR01MB3521CA38E57FA1A5860349DDFA3E0@HK0PR01MB3521.apcprd01.prod.exchangelabs.com>
Date:   Wed, 8 Jan 2020 05:26:35 +0000
From:   Johnson CH Chen (陳昭勳) 
        <JohnsonCH.Chen@...a.com>
To:     Fabio Estevam <festevam@...il.com>, Andrew Lunn <andrew@...n.ch>
CC:     "claudiu.manoil@....com" <claudiu.manoil@....com>,
        "netdev@...r.kernel.org" <netdev@...r.kernel.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        "zero19850401@...il.com" <zero19850401@...il.com>
Subject: RE: [PATCH] gianfar: Solve ethernet TX/RX problems for ls1021a

Hi,

Fabio Estevam <festevam@...il.com> 於 2020年1月7日 週二 下午10:17寫道：
>
> On Tue, Jan 7, 2020 at 11:13 AM Andrew Lunn <andrew@...n.ch> wrote:
> >
> > > diff --git a/drivers/net/ethernet/freescale/gianfar.c 
> > > b/drivers/net/ethernet/freescale/gianfar.c
> > > index 72868a28b621..ab4e45199df9 100644
> > > --- a/drivers/net/ethernet/freescale/gianfar.c
> > > +++ b/drivers/net/ethernet/freescale/gianfar.c
> > > @@ -833,6 +833,7 @@ static int gfar_of_init(struct platform_device 
> > > *ofdev, struct net_device **pdev)
> > >
> > >       /* Find the TBI PHY.  If it's not there, we don't support SGMII */
> > >       priv->tbi_node = of_parse_phandle(np, "tbi-handle", 0);
> > > +     priv->dma_endian_le = of_property_read_bool(np, 
> > > + "fsl,dma-endian-le");
> >
> > Hi Johnson
> >
> > You need to document this new property in the binding.

Thanks yuor remind, I'll take care of it later
>
> Yes, but what about calling it 'little-endian' which is commonly used 
> in arch/arm64/boot/dts/freescale/fsl-lsxxx device trees?
It sounds good, use "dma-endian-le" because it's from freescale's SDK for arm (32bit).

Thanks your suggestions!

Best regards,
Johnson