lists  /  announce  owl-users  owl-dev  john-users  john-dev  passwdqc-users  yescrypt  popa3d-users  /  oss-security  kernel-hardening  musl  sabotage  tlsify  passwords  /  crypt-dev  xvendor  /  Bugtraq  Full-Disclosure  linux-kernel  linux-netdev  linux-ext4  linux-hardening  PHC 
Open Source and information security mailing list archives
Hash Suite: Windows password security audit tool. GUI, reports in PDF.
[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Date:   Wed, 8 Jan 2020 11:13:34 +0100
From:   Björn Töpel <>
To:     John Fastabend <>
Cc:     Netdev <>,
        Alexei Starovoitov <>,
        Daniel Borkmann <>,
        Björn Töpel <>,
        bpf <>, David Miller <>,
        Jakub Kicinski <>,
        Jesper Dangaard Brouer <>,
        "Karlsson, Magnus" <>,
        Jonathan Lemon <>,
        Toke Høiland-Jørgensen <>
Subject: Re: [PATCH bpf-next v2 4/8] xsk: make xskmap flush_list common for
 all map instances

On Tue, 7 Jan 2020 at 18:54, John Fastabend <> wrote:
> Björn Töpel wrote:
> > From: Björn Töpel <>
> >
> > The xskmap flush list is used to track entries that need to flushed
> > from via the xdp_do_flush_map() function. This list used to be
> > per-map, but there is really no reason for that. Instead make the
> > flush list global for all xskmaps, which simplifies __xsk_map_flush()
> > and xsk_map_alloc().
> >
> > Acked-by: Toke Høiland-Jørgensen <>
> > Signed-off-by: Björn Töpel <>
> > ---
> Just to check. The reason this is OK is because xdp_do_flush_map()
> is called from NAPI context and is per CPU so the only entries on
> the list will be from the current cpu napi context?


> Even in the case
> where multiple xskmaps exist we can't have entries from more than
> a single map on any list at the same time by my reading.

No, there can be entries from different (XSK) maps. Instead of
focusing on maps to flush, focus on *entries* to flush. At the end of
the poll function, all entries (regardless of map origin) will be
flushed. Makes sense?


> Acked-by: John Fastabend <>

Powered by blists - more mailing lists