netdev - Re: [PATCH v5 net-next 9/9] net: dsa: felix: Add PCS operations for PHYLINK

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Wed, 8 Jan 2020 13:47:48 +0100
From:   Arnd Bergmann <arnd@...db.de>
To:     Vladimir Oltean <olteanv@...il.com>
Cc:     David Miller <davem@...emloft.net>,
        Jakub Kicinski <jakub.kicinski@...ronome.com>,
        Russell King - ARM Linux <linux@...linux.org.uk>,
        Andrew Lunn <andrew@...n.ch>,
        Florian Fainelli <f.fainelli@...il.com>,
        Vivien Didelot <vivien.didelot@...il.com>,
        alexandru.marginean@....com,
        Claudiu Manoil <claudiu.manoil@....com>,
        xiaoliang.yang_1@....com, yangbo lu <yangbo.lu@....com>,
        Networking <netdev@...r.kernel.org>,
        Alexandre Belloni <alexandre.belloni@...tlin.com>,
        horatiu.vultur@...rochip.com, UNGLinuxDriver@...rochip.com,
        Vladimir Oltean <vladimir.oltean@....com>
Subject: Re: [PATCH v5 net-next 9/9] net: dsa: felix: Add PCS operations for PHYLINK

On Mon, Jan 6, 2020 at 2:37 AM Vladimir Oltean <olteanv@...il.com> wrote:
>
> From: Vladimir Oltean <vladimir.oltean@....com>
>
> Layerscape SoCs traditionally expose the SerDes configuration/status for
> Ethernet protocols (PCS for SGMII/USXGMII/10GBase-R etc etc) in a register
> format that is compatible with clause 22 or clause 45 (depending on
> SerDes protocol). Each MAC has its own internal MDIO bus on which there
> is one or more of these PCS's, responding to commands at a configurable
> PHY address. The per-port internal MDIO bus (which is just for PCSs) is
> totally separate and has nothing to do with the dedicated external MDIO
> controller (which is just for PHYs), but the register map for the MDIO
> controller is the same.

I get randconfig build failures after this patch:

drivers/net/dsa/ocelot/felix_vsc9959.o: In function `vsc9959_mdio_bus_alloc':
felix_vsc9959.c:(.text+0x19c): undefined reference to `enetc_hw_alloc'
felix_vsc9959.c:(.text+0x1d1): undefined reference to `enetc_mdio_read'
felix_vsc9959.c:(.text+0x1d8): undefined reference to `enetc_mdio_write'

I'll send a patch after a bit more testing

       Arnd