netdev - Re: [question] About triggering a region snapshot through the devlink cmd

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <b6fcf0db-1767-51fa-6783-3975ed238d85@intel.com>
Date:   Thu, 9 Jan 2020 12:05:43 -0800
From:   Jacob Keller <jacob.e.keller@...el.com>
To:     Jakub Kicinski <jakub.kicinski@...ronome.com>
Cc:     Alex Vesker <valex@...lanox.com>, davem@...emloft.net,
        Jiri Pirko <jiri@...lanox.com>, linuxarm@...wei.com,
        linyunsheng@...wei.com, netdev@...r.kernel.org,
        Jiri Pirko <jiri@...nulli.us>
Subject: Re: [question] About triggering a region snapshot through the devlink
 cmd

On 1/9/2020 11:41 AM, Jakub Kicinski wrote:
> On Wed, 8 Jan 2020 11:14:38 -0800, Jacob Keller wrote:
>> On 1/8/2020 4:15 AM, Alex Vesker wrote:
>>> I am a biased here but, devlink trigger can be useful... I am not aware
>>> of other alternatives,
>>> devlink health has it`s benefits but it is not devlink region. If you
>>> will decide to implement I can
>>> review the design, if Jiri is ok with the idea.
>>>   
>>
>> Sure. I am not quite sure how long it will be till patches are on the
>> list, as I'm currently in the process of implementing devlink support
>> for one of the Intel drivers, and would be using that driver as an example.
>>
>> Actually, come to think of it, I may just implement the region trigger
>> and use netdevsim as the example. That should enable those patches to
>> hit the list sooner than the patches for implementing devlink for the
>> ice driver.
> 
> Just to be clear - you mean implement triggering the dump over netlink?
> FWIW that seems fairly reasonable to me, but please do explain the use
> case clearly in the patches.
> 

Yes. See the patches I just sent and let me know if the explanation
isn't totally clear.

> netdevsim is a driver mock up, and debugfs is its control interface.
> The trigger there is to simulate an async device error, this trigger
> should not be used as example or justification for anything real driver
> may need.
> 

The only two drivers that currently use regions at all are the mlx4 and
the netdevsim driver. In order to have some example of how the new
.trigger_snapshot and DEVLINK_CMD_REGION_TRIGGER work, (and so I could
test them out easily) I chose to implement it in netdevsim.

I'm working on patches for the ice driver that will implement devlink
support, but that is still in progress and isn't really yet at a point
where I can send it to the list. I wanted to get feedback on the
implementation of the triggering earlier.

Thanks,
Jake