netdev - Re: [PATCH bpf-next] selftests/bpf: restore original comm in test

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAPhsuW6_Xwo3x59B==NhnboQFY_xFqO8vn+OXeXzhnKGjyJiGg@mail.gmail.com>
Date:   Wed, 8 Jan 2020 17:04:56 -0800
From:   Song Liu <song@...nel.org>
To:     Petar Penkov <ppenkov.kernel@...il.com>
Cc:     Stanislav Fomichev <sdf@...gle.com>,
        Networking <netdev@...r.kernel.org>, bpf <bpf@...r.kernel.org>,
        "David S . Miller" <davem@...emloft.net>,
        Alexei Starovoitov <ast@...nel.org>,
        Daniel Borkmann <daniel@...earbox.net>
Subject: Re: [PATCH bpf-next] selftests/bpf: restore original comm in test_overhead

On Wed, Jan 8, 2020 at 3:19 PM Petar Penkov <ppenkov.kernel@...il.com> wrote:
>
> On Wed, Jan 8, 2020 at 11:49 AM Stanislav Fomichev <sdf@...gle.com> wrote:
> >
> > test_overhead changes task comm in order to estimate BPF trampoline
> > overhead but never sets the comm back to the original one.
> > We have the tests (like core_reloc.c) that have 'test_progs'
> > as hard-coded expected comm, so let's try to preserve the
> > original comm.
> >
> > Currently, everything works because the order of execution is:
> > first core_recloc, then test_overhead; but let's make it a bit
> > future-proof.
> >
> > Other related changes: use 'test_overhead' as new comm instead of
> > 'test' to make it easy to debug and drop '\n' at the end.
> >
> > Signed-off-by: Stanislav Fomichev <sdf@...gle.com>
>
> Acked-by: Petar Penkov <ppenkov@...gle.com>

Acked-by: Song Liu <songliubraving@...com>