netdev - Re: [PATCH net-next] ethtool: fix ->reply

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20200108.160359.356749095676572714.davem@davemloft.net>
Date:   Wed, 08 Jan 2020 16:03:59 -0800 (PST)
From:   David Miller <davem@...emloft.net>
To:     dan.carpenter@...cle.com
Cc:     mkubecek@...e.cz, f.fainelli@...il.com, andrew@...n.ch,
        netdev@...r.kernel.org, kernel-janitors@...r.kernel.org
Subject: Re: [PATCH net-next] ethtool: fix ->reply_size() error handling

From: Dan Carpenter <dan.carpenter@...cle.com>
Date: Wed, 8 Jan 2020 08:41:25 +0300

> The "ret < 0" comparison is never true because "ret" is still zero.
> 
> Fixes: 728480f12442 ("ethtool: default handlers for GET requests")
> Signed-off-by: Dan Carpenter <dan.carpenter@...cle.com>

Applied.