netdev - Re: [PATCH net-next 02/10] ipv4: Encapsulate function arguments in a struct

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20200109082646.GA273688@splinter>
Date:   Thu, 9 Jan 2020 10:26:46 +0200
From:   Ido Schimmel <idosch@...sch.org>
To:     David Ahern <dsahern@...il.com>
Cc:     netdev@...r.kernel.org, davem@...emloft.net, jiri@...lanox.com,
        jakub.kicinski@...ronome.com, roopa@...ulusnetworks.com,
        mlxsw@...lanox.com, Ido Schimmel <idosch@...lanox.com>
Subject: Re: [PATCH net-next 02/10] ipv4: Encapsulate function arguments in a
 struct

On Wed, Jan 08, 2020 at 11:37:28AM -0700, David Ahern wrote:
> On 1/7/20 8:45 AM, Ido Schimmel wrote:
> > diff --git a/net/ipv4/fib_lookup.h b/net/ipv4/fib_lookup.h
> > index a68b5e21ec51..b34594a9965f 100644
> > --- a/net/ipv4/fib_lookup.h
> > +++ b/net/ipv4/fib_lookup.h
> > @@ -21,6 +21,15 @@ struct fib_alias {
> >  
> >  #define FA_S_ACCESSED	0x01
> >  
> > +struct fib_rt_info {
> > +	struct fib_info		*fi;
> > +	u32			tb_id;
> > +	__be32			dst;
> > +	int			dst_len;
> > +	u8			tos;
> > +	u8			type;
> > +};
> > +
> >  /* Dont write on fa_state unless needed, to keep it shared on all cpus */
> >  static inline void fib_alias_accessed(struct fib_alias *fa)
> >  {
> > @@ -35,9 +44,8 @@ struct fib_info *fib_create_info(struct fib_config *cfg,
> >  int fib_nh_match(struct fib_config *cfg, struct fib_info *fi,
> >  		 struct netlink_ext_ack *extack);
> >  bool fib_metrics_match(struct fib_config *cfg, struct fib_info *fi);
> > -int fib_dump_info(struct sk_buff *skb, u32 pid, u32 seq, int event, u32 tb_id,
> > -		  u8 type, __be32 dst, int dst_len, u8 tos, struct fib_info *fi,
> > -		  unsigned int);
> > +int fib_dump_info(struct sk_buff *skb, u32 pid, u32 seq, int event,
> > +		  struct fib_rt_info *fri, unsigned int);
> 
> since you are modifying this, can you add a name for that last argument?

Yes, will add in v2

> 
> 
> Otherwise, nice cleanup.
> 
> Reviewed-by: David Ahern <dsahern@...il.com>

Thanks!